Skip to content

Allow customization of SQL queries #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Jun 10, 2024

Description

Allows passing custom column definitions when generating SQL. For Databricks
SQL, the xsd:dateTime type is now always mapped to Databricks TIMESTAMP.

Fixes #587

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

Add any other notes or comments here.

Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atextor atextor merged commit 36804d5 into eclipse-esmf:main Jun 10, 2024
4 checks passed
@atextor atextor deleted the 587-allow-custom-columns-in-sql-schema-generation branch June 10, 2024 14:24
Copy link

Release v2.8.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Make SQL schema generation customizable with custom columns
2 participants